test: add benchmarks #12
Conversation
elhimov
force-pushed
the
elhimov/tntp-3733-import-and-actualize-benchmarks
branch
from
e796751 to
4dd55cd
Compare
elhimov
requested review from
AlexandrLitkevich,
bigbes and
oleg-jukovec
and removed request for
oleg-jukovec
elhimov
force-pushed
the
elhimov/tntp-3733-import-and-actualize-benchmarks
branch
6 times, most recently
from
ece055f to
fdd30f4
Compare
| .PHONY: bench | ||
| bench: | ||
| @echo "Running benchmarks" | ||
| @go test ./... -count=1 -bench=. -benchmem |
There was a problem hiding this comment.
Do we really need the benchmem? If so - ok.
There was a problem hiding this comment.
-benchmem will show allocation count, I think it's necessary information for us to use.
There was a problem hiding this comment.
We are interested in number of allocation and this option displays allocation statistic.
| dec := msgpack.GetDecoder() | ||
| dec.Reset(&buf) | ||
|
|
||
| b.Run("Optional1Bench", func(b *testing.B) { |
There was a problem hiding this comment.
Does it a go-idiomic practice to name the tests in the manner? Why do we need the CamelCase here? Why not just "optional simple bench" or so on?
Up to @bigbes .
There was a problem hiding this comment.
Well, I don't have any strong opinion about naming of subtests. On one hand I'm preferring to have name that I can copy to cli to run subtest, but go-idiomatic way is to write clear names with spaces in lowercase.
Let's stick with go-idiomatic way there.
|
Pls, add
|
Probably we could just update the README.md instead of a separate document. The README.md now is small and shouldn't become too big. |
Closes TNTP-3733
elhimov
force-pushed
the
elhimov/tntp-3733-import-and-actualize-benchmarks
branch
from
fdd30f4 to
e6db0a0
Compare
4 participants
I didn't forget about (remove if it is not applicable):
Related issues:
Closes TNTP-3733